[KDE/Mac] Review Request 128188: [OS X] Show job progress with Dock icon badge

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128188/
-----------------------------------------------------------

(Updated June 15, 2016, 12:11 a.m.)


Review request for KDE Software on Mac OS X and KDevelop.


Changes
-------

Well, that was easy. Qt Creator has its dock progress bar implementation in easy view, so it was trivial to use it as the basis of a similar feature for KDevelop. I suppose I should mention that somewhere, possibly in the copyright header?

@Kai: did you see the `shell/progresswidget` directory? Shouldn't our progress widget implementation files be stored there ... and would that not also be the place to find the code for the togglable progress widget where we might have access to information from the background parser too?


Repository: kdevplatform


Description
-------

This is a follow-up to https://git.reviewboard.kde.org/r/127050/, providing a job progress indication in the Dock (and app switcher), by badging the application icon.

Is it correct that the `RunController` is not used by the (Clang) parser? If so, shouldn't this progress indication (and the Unity one) be moved to the method that updates the progress bar in KDevelop's lower right corner?


Diffs (updated)
-----

  shell/CMakeLists.txt 19a9560 
  shell/macdockprogressview.h PRE-CREATION 
  shell/macdockprogressview.mm PRE-CREATION 
  shell/runcontroller.cpp 1a411da 

Diff: https://git.reviewboard.kde.org/r/128188/diff/


Testing
-------

Works on OS X 10.9.5 with Qt 5.6.0 and frameworks 5.22.0


File Attachments (updated)
----------------

progress badge on a Dock icon
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/e800031a-378b-46fb-88cf-ee55c78d7a1f__Screen_Shot_2016-06-14_at_20.30.55.png
dock icon with progress bar
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/295a93b7-3802-4501-b2dc-3bdf8fa4048b__Screen_Shot_2016-06-15_at_00.02.05.png


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160614/cef589a6/attachment.html>