[KDE/Mac] Review Request 128130: [OS X/Qt4] prevent menu rendering artefacts

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128130/
-----------------------------------------------------------

(Updated June 9, 2016, 6:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Software on Mac OS X and Yichao Yu.


Changes
-------

Submitted with commit aba67e49340188c669527ea4dc04af019571f29d by René J.V. Bertin to branch master.


Repository: qtcurve


Description
-------

Qt4 for Mac OS X has certain shortcomings that can cause rendering artefacts when compositing is used. In QtCurve this can be avoided which made it the preferred widget style for the MacPorts KDE4 ports.
The artefact does occur when using rounded popup menus. Popup menus ought to have rounded corners in order to follow the native style. This works fine under Qt5 but with Qt4 this causes menus to appear empty except under the mouse cursor.

Since the Qt4 and Qt5 styles share a single preferences file, I propose a patch for qt4/qtcurve.cpp . This makes the code pretend (on OS X) that the "square popup menus" attribute is always set, regardless of the actual setting


Diffs
-----

  qt4/style/qtcurve.cpp 059d906 

Diff: https://git.reviewboard.kde.org/r/128130/diff/


Testing
-------

On OS X 10.9 and Linux, both with Qt 4.8.7 and Qt 5.6.0


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160609/074c35af/attachment.html>