[KDE/Mac] Review Request 128188: [OS X] Show job progress with Dock icon badge
René J.V. Bertin
rjvbertin at gmail.com
Thu Jul 14 11:14:42 UTC 2016
> On July 10, 2016, 2 p.m., Milian Wolff wrote:
> > shell/progresswidget/statusbarprogresswidget.cpp, line 185
> > <https://git.reviewboard.kde.org/r/128188/diff/6/?file=471144#file471144line185>
> >
> > -1 for making this all static, or can there really just be one dock progress view?
>
> René J.V. Bertin wrote:
> Yes, there is only 1 Dock tile per application instance. Windows can be shown as individual tiles in a specific part of the Dock, but only when they're minimised (and the user didn't change the corresponding option).
>
> So the only way to have multiple progress views would be to draw more than one on the single Dock tile. That's possible of course, but do you really think that's a good idea when you look at the screenshots
>
> Milian Wolff wrote:
> OK, nvm then. And +1 to merge it in for now, but please, pretty please, move this together with the unity stuff into a proper framework. `kwidgetsaddons` comes into mind.
>
> Kai Uwe Broulik wrote:
> There is currently a Window Metadata framework being worked on which this should go into.
>
> René J.V. Bertin wrote:
> Window or *Windows*? I don't really see how job/task progress relates to window-specific metadata, but I suppose the framework's description will make that clear.
>
> And for the record: I think I've already said it but I'm all for putting this sort of thing in a framework or library where it can serve other applications as well. I only won't have much opportunity to do much development for the next couple of weeks.
We should also watch the Qt mailing lists. I brought up the suggestion to add this kind of feature to Qt itself and that was rather well received.
In the meantime I committed this (http://commits.kde.org/kdevplatform/c0626300e1c18448dd653a3484fd1ca6298e2d8c; hoping I didn't mis-interpret Milian's remark above). This RR should have been closed but I got an error I never saw before:
```
> git push
Counting objects: 9, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 3.10 KiB | 0 bytes/s, done.
Total 9 (delta 7), reused 0 (delta 0)
remote: Traceback (most recent call last):
remote: File "/home/git/repo-management/hooks/update_review.py", line 160, in <module>
remote: main()
remote: File "/home/git/repo-management/hooks/update_review.py", line 156, in main
remote: close_review(review_id, commit_id, committer, author, ref_change)
remote: File "/home/git/repo-management/hooks/update_review.py", line 110, in close_review
remote: data=dict(status="submitted", close_description=message))
remote: File "/usr/lib/python3/dist-packages/requests/api.py", line 105, in put
remote: return request('put', url, data=data, **kwargs)
remote: File "/usr/lib/python3/dist-packages/requests/api.py", line 49, in request
remote: return session.request(method=method, url=url, **kwargs)
remote: File "/usr/lib/python3/dist-packages/requests/sessions.py", line 443, in request
remote: prep = self.prepare_request(req)
remote: File "/usr/lib/python3/dist-packages/requests/sessions.py", line 374, in prepare_request
remote: hooks=merge_hooks(request.hooks, self.hooks),
remote: File "/usr/lib/python3/dist-packages/requests/models.py", line 307, in prepare
remote: self.prepare_body(data, files, json)
remote: File "/usr/lib/python3/dist-packages/requests/models.py", line 452, in prepare_body
remote: body = self._encode_params(data)
remote: File "/usr/lib/python3/dist-packages/requests/models.py", line 97, in _encode_params
remote: v.encode('utf-8') if isinstance(v, str) else v))
remote: UnicodeEncodeError: 'utf-8' codec can't encode character '\udcc3' in position 69: surrogates not allowed
remote: This commit is available for viewing at:
remote: http://commits.kde.org/kdevplatform/c0626300e1c18448dd653a3484fd1ca6298e2d8c
To ssh://git@git.kde.org/kdevplatform
8d0fcb8..c062630 master -> master
```
Any idea if that's due to what I pushed?
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128188/#review97257
-----------------------------------------------------------
On July 5, 2016, 8:32 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128188/
> -----------------------------------------------------------
>
> (Updated July 5, 2016, 8:32 p.m.)
>
>
> Review request for KDE Software on Mac OS X and KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> This is a follow-up to https://git.reviewboard.kde.org/r/127050/, providing a job progress indication in the Dock (and app switcher), by badging the application icon.
>
> Is it correct that the `RunController` is not used by the (Clang) parser? If so, shouldn't this progress indication (and the Unity one) be moved to the method that updates the progress bar in KDevelop's lower right corner?
>
>
> Diffs
> -----
>
> shell/CMakeLists.txt 19a9560
> shell/macdockprogressview.h PRE-CREATION
> shell/macdockprogressview.mm PRE-CREATION
> shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8
>
> Diff: https://git.reviewboard.kde.org/r/128188/diff/
>
>
> Testing
> -------
>
> Works on OS X 10.9.5 with Qt 5.6.0 and frameworks 5.22.0
>
>
> File Attachments
> ----------------
>
> progress badge on a Dock icon
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/e800031a-378b-46fb-88cf-ee55c78d7a1f__Screen_Shot_2016-06-14_at_20.30.55.png
> dock icon with progress bar
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/295a93b7-3802-4501-b2dc-3bdf8fa4048b__Screen_Shot_2016-06-15_at_00.02.05.png
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160714/1b44601b/attachment-0001.html>
More information about the kde-mac
mailing list