[KDE/Mac] Review Request 128188: [OS X] Show job progress with Dock icon badge

[Milian Wolff]

> On July 10, 2016, noon, Milian Wolff wrote:
> > shell/progresswidget/statusbarprogresswidget.cpp, line 185
> > <https://git.reviewboard.kde.org/r/128188/diff/6/?file=471144#file471144line185>
> >
> >     -1 for making this all static, or can there really just be one dock progress view?
> 
> René J.V. Bertin wrote:
>     Yes, there is only 1 Dock tile per application instance. Windows can be shown as individual tiles in a specific part of the Dock, but only when they're minimised (and the user didn't change the corresponding option).
>     
>     So the only way to have multiple progress views would be to draw more than one on the single Dock tile. That's possible of course, but do you really think that's a good idea when you look at the screenshots

OK, nvm then. And +1 to merge it in for now, but please, pretty please, move this together with the unity stuff into a proper framework. `kwidgetsaddons` comes into mind.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128188/#review97257
-----------------------------------------------------------


On July 5, 2016, 6:32 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128188/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 6:32 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is a follow-up to https://git.reviewboard.kde.org/r/127050/, providing a job progress indication in the Dock (and app switcher), by badging the application icon.
> 
> Is it correct that the `RunController` is not used by the (Clang) parser? If so, shouldn't this progress indication (and the Unity one) be moved to the method that updates the progress bar in KDevelop's lower right corner?
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 19a9560 
>   shell/macdockprogressview.h PRE-CREATION 
>   shell/macdockprogressview.mm PRE-CREATION 
>   shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 
> 
> Diff: https://git.reviewboard.kde.org/r/128188/diff/
> 
> 
> Testing
> -------
> 
> Works on OS X 10.9.5 with Qt 5.6.0 and frameworks 5.22.0
> 
> 
> File Attachments
> ----------------
> 
> progress badge on a Dock icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/e800031a-378b-46fb-88cf-ee55c78d7a1f__Screen_Shot_2016-06-14_at_20.30.55.png
> dock icon with progress bar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/295a93b7-3802-4501-b2dc-3bdf8fa4048b__Screen_Shot_2016-06-15_at_00.02.05.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160710/ff7e670e/attachment-0001.html>