[KDE/Mac] Review Request 128188: [OS X] Show job progress with Dock icon badge

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128188/#review97257
-----------------------------------------------------------




shell/macdockprogressview.mm (line 2)
<https://git.reviewboard.kde.org/r/128188/#comment65663>

    This smells like framework material to me. I doubt KDevelop is the only one who wants this feature. Can you please push it somewhere meaningful? Paired with the unity implementation and whatever was/is required for plasma (or is that using the unit dbus interface?).
    
    Kai, could you help Rene with that please?



shell/progresswidget/statusbarprogresswidget.cpp (line 185)
<https://git.reviewboard.kde.org/r/128188/#comment65664>

    -1 for making this all static, or can there really just be one dock progress view?


- Milian Wolff


On July 5, 2016, 6:32 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128188/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 6:32 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is a follow-up to https://git.reviewboard.kde.org/r/127050/, providing a job progress indication in the Dock (and app switcher), by badging the application icon.
> 
> Is it correct that the `RunController` is not used by the (Clang) parser? If so, shouldn't this progress indication (and the Unity one) be moved to the method that updates the progress bar in KDevelop's lower right corner?
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 19a9560 
>   shell/macdockprogressview.h PRE-CREATION 
>   shell/macdockprogressview.mm PRE-CREATION 
>   shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 
> 
> Diff: https://git.reviewboard.kde.org/r/128188/diff/
> 
> 
> Testing
> -------
> 
> Works on OS X 10.9.5 with Qt 5.6.0 and frameworks 5.22.0
> 
> 
> File Attachments
> ----------------
> 
> progress badge on a Dock icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/e800031a-378b-46fb-88cf-ee55c78d7a1f__Screen_Shot_2016-06-14_at_20.30.55.png
> dock icon with progress bar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/295a93b7-3802-4501-b2dc-3bdf8fa4048b__Screen_Shot_2016-06-15_at_00.02.05.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160710/b71742ee/attachment.html>