[KDE/Mac] Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128043/#review97008
-----------------------------------------------------------




src/notifybyaudio.cpp (line 85)
<https://git.reviewboard.kde.org/r/128043/#comment65544>

    So if the user upgrades from Plasma 5 to Plasma 6, and the old sound file no longer exists, the user is going to be rewarded with an awful BEEEP ?
    
    I truly hate audio notifications, but the system beep is even 10 times higher on my hate list. What if my wife is sleeping on the sofa next to me?
    
    Is QApplication::beep() muted by the laptop's mute button btw? On old desktop PCs I remember it was completely independent from the mixer settings.


- David Faure


On June 9, 2016, 5:52 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128043/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 5:52 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> This is a follow-up to discussion on the plasma-devel ML. When not running under a Plasma session it would be preferable if generic alert sounds are (can be) delivered using the default system sound. The easiest way to do that is to call `QApplication::beep()` ; at least on OS X this will play the user's selected alert sound.
> 
> I have implemented this for now by assuming the existence of a virtual (relative) `beep` sound file that always plays the default sound. 
> 
> In addition, this patch provides better warning feedback if a soundfile isn't found (making it easier to figure out which alert is misconfigured), and will play the sysbeep in that case (so that the alert doesn't go lost if it's sound-only).
> Finally, no Phonon::AudioOutput object is created until that is actually required.
> 
> 
> Diffs
> -----
> 
>   src/notifybyaudio.cpp 903e996 
> 
> Diff: https://git.reviewboard.kde.org/r/128043/diff/
> 
> 
> Testing
> -------
> 
> Works as expected on OS X 10.9.5
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160702/c24e3402/attachment.html>