[KDE/Mac] Fwd: Change in qt/qtbase[dev]: Also search the main bundle plugin path for plugins on Apple...

[David Faure]

FYI

----------  Forwarded Message  ----------

Subject: Change in qt/qtbase[dev]: Also search the main bundle plugin path for plugins on Apple...
Date: Thursday 25 February 2016, 19:45:44
From: Qt CI Bot (Code Review) <gerrit-noreply at qt-project.org>
To: Jake Petroules <jake.petroules at theqtcompany.com>
CC: Oswald Buddenhagen <oswald.buddenhagen at theqtcompany.com>, Tor Arne Vestbø <tor.arne.vestbo at theqtcompany.com>, Morten Johan Sørvig <morten.sorvig at theqtcompany.com>, Qt Sanity Bot <qt_sanitybot at qt-project.org>, Richard Moe Gustavsen <richard.gustavsen at theqtcompany.com>, Gabriel de Dietrich <gabriel.dedietrich at theqtcompany.com>, Timur Pocheptsov <timur.pocheptsov at theqtcompany.com>, Thiago Macieira <thiago.macieira at intel.com>, David Faure <david.faure at kdab.com>, Mike Krus <mike.krus at kdab.com>

Qt CI Bot has approved a build with this change and it was merged.

Change subject: Also search the main bundle plugin path for plugins on Apple OSes.
......................................................................


Also search the main bundle plugin path for plugins on Apple OSes.

The default value of QLibraryInfo::PluginsPath is $prefix/plugins,
where $prefix is the path to the bundle's contents directory
(for example, .../foo.app/Contents/ on OS X, or .../foo.app/ on iOS).

On Apple platforms the directory is actually called "PlugIns".
Plugins could previously be loaded on OS X by coincidence, but
if the system is using an HFS+ Case Sensitive filesystem (and this
is ALWAYS the case on iOS-like operating systems), the case
mismatch would cause plugins in an application bundle not to be
found/loaded.

This change allows plugins to be located in application bundles
on Apple platforms regardless of the HFS+ case sensitivity mode
and without needing to specify a qt.conf file.

Change-Id: Ie0a0f7448fbf5fb410aa77944ba0d01895bb05e3
---
M src/corelib/kernel/qcoreapplication.cpp
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Morten Johan Sørvig: Looks good to me, approved
  Qt Sanity Bot: Sanity review passed
  Oswald Buddenhagen: Looks good to me, but someone else must approve


-- 
To view, visit https://codereview.qt-project.org/149771
To unsubscribe, visit https://codereview.qt-project.org/settings

Gerrit-MessageType: build-approved
Gerrit-Change-Id: Ie0a0f7448fbf5fb410aa77944ba0d01895bb05e3
Gerrit-PatchSet: 5
Gerrit-Project: qt/qtbase
Gerrit-Branch: dev
Gerrit-Owner: Jake Petroules <jake.petroules at theqtcompany.com>
Gerrit-Reviewer: David Faure <david.faure at kdab.com>
Gerrit-Reviewer: Gabriel de Dietrich <gabriel.dedietrich at theqtcompany.com>
Gerrit-Reviewer: Jake Petroules <jake.petroules at theqtcompany.com>
Gerrit-Reviewer: Mike Krus <mike.krus at kdab.com>
Gerrit-Reviewer: Morten Johan Sørvig <morten.sorvig at theqtcompany.com>
Gerrit-Reviewer: Oswald Buddenhagen <oswald.buddenhagen at theqtcompany.com>
Gerrit-Reviewer: Qt Sanity Bot <qt_sanitybot at qt-project.org>
Gerrit-Reviewer: Richard Moe Gustavsen <richard.gustavsen at theqtcompany.com>
Gerrit-Reviewer: Thiago Macieira <thiago.macieira at intel.com>
Gerrit-Reviewer: Timur Pocheptsov <timur.pocheptsov at theqtcompany.com>
Gerrit-Reviewer: Tor Arne Vestbø <tor.arne.vestbo at theqtcompany.com>
-----------------------------------------
-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5