[KDE/Mac] Review Request 127084: [OS X] provide a fully populated Info.plist

[Aleix Pol Gonzalez]

> On Feb. 16, 2016, 2:55 p.m., Kevin Funk wrote:
> > kate/CMakeLists.txt, line 114
> > <https://git.reviewboard.kde.org/r/127084/diff/1/?file=444431#file444431line114>
> >
> >     Minor: You don't need `endif(EXPR)` these days anymore. `endif()` is sufficient.
> 
> René J.V. Bertin wrote:
>     True - that'd apply to the kdevelop/app/CMakelists.txt file from which I copied and adapted this block too ;)
>     
>     IIRC the short form has been possible for quite some time already, but in KDE4 days there appeared to be a preference for the fully specified variant. So that has changed, there is now an official preference to using the short variant?
> 
> Kevin Funk wrote:
>     I don't see the verbose variant being used in modern CMake code.
>     
>     Try:
>     `ack endif /usr/share/cmake-*/Modules`
>     
>     The new modules in ECM don't use it either.

Yes: https://techbase.kde.org/Policies/CMake_Coding_Style


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127084/#review92446
-----------------------------------------------------------


On Feb. 15, 2016, 10:20 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127084/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2016, 10:20 p.m.)
> 
> 
> Review request for Kate and KDE Software on Mac OS X.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Since the recent modification that allows Kate to open documents "served" through the Finder, the application showed up with an icon but no name (e.g. in the Activity Monitor).
> 
> This turned out to be the result of an incompletely filled-in Info.plist, from which much relevant information was missing.
> It is apparently required to do this by hand if one uses a custom Info.plist template; the present patch shows how (for kate only; kwrite would require the same treatment).
> 
> 
> Diffs
> -----
> 
>   kate/CMakeLists.txt 3b24e08 
> 
> Diff: https://git.reviewboard.kde.org/r/127084/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with Qt 5.5.1 and FWs 5.19.0
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160216/007aefec/attachment.html>