Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

Tue Dec 27 17:39:00 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126291/#review101602
-----------------------------------------------------------


src/kwindowsystem.cpp (lines 728 - 732)
<https://git.reviewboard.kde.org/r/126291/#comment68017>

    why did you ifdef the section? It's just a runtime switch not depending on any platform specific libraries like the X11 case.


src/platforms/osx/kwindowinfo.mm (line 33)
<https://git.reviewboard.kde.org/r/126291/#comment68020>

    what's "Ext"?


src/platforms/osx/kwindowinfo.mm (line 36)
<https://git.reviewboard.kde.org/r/126291/#comment68018>

    ?


src/platforms/osx/kwindowinfo.mm (lines 38 - 40)
<https://git.reviewboard.kde.org/r/126291/#comment68019>

    why are there both public and private variables? For a d-ptr class I don't really understand this


src/platforms/osx/kwindowinfo.mm (lines 273 - 276)
<https://git.reviewboard.kde.org/r/126291/#comment68021>

    ?


src/platforms/osx/kwindowinfo.mm (line 336)
<https://git.reviewboard.kde.org/r/126291/#comment68022>

    QByteArrayLiteral


src/platforms/osx/kwindowinfo.mm (line 346)
<https://git.reviewboard.kde.org/r/126291/#comment68023>

    QByteArrayLiteral


src/platforms/osx/kwindowinfo.mm (line 349)
<https://git.reviewboard.kde.org/r/126291/#comment68025>

    I'm pretty sure the NETWM spec is irrelevant on cocoa


src/platforms/osx/kwindowinfo_p_cocoa.h (line 74)
<https://git.reviewboard.kde.org/r/126291/#comment68026>

    wtf is that?


src/platforms/osx/kwindowsystem.cpp (lines 47 - 53)
<https://git.reviewboard.kde.org/r/126291/#comment68027>

    ?


src/platforms/osx/kwindowsystem_mac_p.h (line 24)
<https://git.reviewboard.kde.org/r/126291/#comment68028>

    do we really need this? That's way too much ifedery for me. Either we have that feature or not. Have finished things I don't want to see in our code.


src/platforms/osx/kwindowsystem_macobjc.mm (lines 63 - 65)
<https://git.reviewboard.kde.org/r/126291/#comment68029>

    ?


src/platforms/osx/kwindowsystem_macobjc.mm (line 104)
<https://git.reviewboard.kde.org/r/126291/#comment68032>

    is there a possibility that Qt does not use Cocoa?


src/platforms/osx/kwindowsystem_macobjc.mm (line 108)
<https://git.reviewboard.kde.org/r/126291/#comment68030>

    ?


src/platforms/osx/kwindowsystem_macobjc.mm (lines 111 - 113)
<https://git.reviewboard.kde.org/r/126291/#comment68031>

    ?


src/platforms/osx/kwindowsystem_macobjc.mm (lines 137 - 138)
<https://git.reviewboard.kde.org/r/126291/#comment68033>

    ?


src/platforms/osx/kwindowsystem_macobjc.mm (lines 286 - 295)
<https://git.reviewboard.kde.org/r/126291/#comment68034>

    ?


src/platforms/osx/kwindowsystem_macobjc.mm (lines 301 - 324)
<https://git.reviewboard.kde.org/r/126291/#comment68035>

    ?


src/platforms/osx/kwindowsystem_macobjc.mm (line 518)
<https://git.reviewboard.kde.org/r/126291/#comment68036>

    ?


src/platforms/osx/plugin.h (line 2)
<https://git.reviewboard.kde.org/r/126291/#comment68037>

    I'm certainly not the author of this header file


src/platforms/osx/plugin.cpp (line 2)
<https://git.reviewboard.kde.org/r/126291/#comment68038>

    Also not the author of this file.


- Martin Gräßlin


On Dec. 27, 2016, 5 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126291/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2016, 5 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> KWindowSystem has been lacking a platform plugin for OS X. This RR presents a "backport" of the modified KDE4 KWindowSystem implementation that has been used in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years.
> 
> I have made some initial steps to remove deprecated Carbon API calls, but this is clearly a work in progress.
> 
> Open questions include
> - is there any justification to run an event handler (or Cocoa observer) to keep track of running applications, possibly even listing all their open windows?
> - is there any use for the Qt event listener framework (cf. the NETEventFilter in the X11 plugin)? I haven't yet had time to try to figure out what this "could be good for", and am very open to suggestions in this departments.
> - one application for such an event filter would be a listener that catches the opening and closing of all windows by the running process, and keeps track of their `WId`s. A new method could then be added (to `KWindowInfo`?) to distinguish `WId`s created by the running application from "foreign" ones (useful also on Wayland and MS Windows).
> 
> `KWindowSystem::setMainWindow` should become a front for payload provided by the plugins. I'll leave that to the regular/official maintainer(s) of this framework.
> 
> This code could probably do with *lots* of comments; I'll try to add them as questions about this or that bit of code arise.
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem.h a282ecd 
>   src/kwindowsystem.cpp fda1682 
>   src/platforms/osx/CMakeLists.txt 4fc3347 
>   src/platforms/osx/cocoa.json PRE-CREATION 
>   src/platforms/osx/kkeyserver.cpp 3ddb921 
>   src/platforms/osx/kwindowinfo.cpp e8555bb 
>   src/platforms/osx/kwindowinfo.mm PRE-CREATION 
>   src/platforms/osx/kwindowinfo_mac_p.h c8f307e 
>   src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION 
>   src/platforms/osx/kwindowsystem.cpp 1758829 
>   src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION 
>   src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION 
>   src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION 
>   src/platforms/osx/plugin.h PRE-CREATION 
>   src/platforms/osx/plugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126291/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20161227/09773119/attachment-0001.html>