Review Request 122758: [OS X] work around missing Q_COMPILER_INITIALIZER_LISTS

René J.V. Bertin rjvbertin at gmail.com
Tue Dec 13 14:44:39 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122758/
-----------------------------------------------------------

(Updated Dec. 13, 2016, 3:44 p.m.)


Review request for KDE Software on Mac OS X and KDevelop.


Changes
-------

rebased.


Repository: kdev-python


Description
-------

OS X lacks (full) support for compiler initialiser lists, i.e. Q_COMPILER_INITIALIZER_LISTS is not defined. As a result, several expressions used in kdev-python C++ code fail to compile.

This patch presents a workaround. I have used dynamically allocated class instances where an initialiser list is returned from a function, to avoid returning references to out-of-scope objects.

Please correct me if there are better ways, or if that means the objects have to deleted explicitly by the caller in order to prevent memory leaks.


Diffs (updated)
-----

  duchain/contextbuilder.cpp 79db2fad 
  duchain/tests/pyduchaintest.cpp 05da74f5 
  pythonlanguagesupport.cpp d8a720f6 

Diff: https://git.reviewboard.kde.org/r/122758/diff/


Testing
-------

On OS X/MacPorts with KDE libs 4.14.5 and KDevelop 4.7.1 .


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20161213/967e7ea2/attachment.html>


More information about the kde-mac mailing list