[KDE/Mac] Review Request 127638: build system option to build "kdev-clang" and the rest of the IDE separately

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127638/#review94558
-----------------------------------------------------------



-2

the ide without the plugins is unusable, this patch makes zero sense to me.

also note that you can already disable sub folders if you really want to do that (I doubt it). Just look at the cache via ccmake e.g.:

```
 BUILD_TESTING                    ON
 BUILD_clang                      ON
 BUILD_cmake                      ON
 BUILD_cmakebuilder               ON
 BUILD_custom-buildsystem         ON
 BUILD_custom-definesandinclude   ON
 BUILD_custommake                 ON
 BUILD_executeplasmoid            ON
 BUILD_ghprovider                 ON
 BUILD_kdeprovider                ON
 BUILD_kdev_includepathsconvert   ON
 BUILD_kdev_makefileresolver      OFF
 BUILD_kdev_msvcdefinehelper      OFF
 BUILD_manpage                    ON
 BUILD_plugins                    ON
 BUILD_qmake                      ON
 BUILD_qmake_parser               OFF
 BUILD_qmakebuilder               ON
 BUILD_qmljs                      ON
 BUILD_qthelp                     ON
```

- Milian Wolff


On April 12, 2016, 4:34 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127638/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 4:34 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch is in reaction to a discussion on kdevelop-devel about weakening KDevelop's dependency on a specific Clang (libclang) version.
> 
> The patch introduces 2 CMake options:
> - `KDEVELOP_BUILD_IDE` builds just the IDE, without the clang-based parser (formerly kdev-clang)
> - `KDEVELOP_BUILD_CLANG_PARSER` builds just the clang-based parser
> 
> Nothing changes when both options are on (the default): all of KDevelop is built. When both options are off, an error is raised.
> 
> The idea is that this should make it a little bit easier for distributions/packaging systems and users to change the clang toolchain.
> 
> I presume that the languages subdirectory could be built first or last (that would the patch a bit simpler)?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2d3faa7 
>   languages/CMakeLists.txt 4e2fde2 
>   languages/clang/CMakeLists.txt c19a951 
> 
> Diff: https://git.reviewboard.kde.org/r/127638/diff/
> 
> 
> Testing
> -------
> 
> On OS X and Linux, against Qt 5.6.0, FWs 5.20.0, prefix=/opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160412/cba9c745/attachment.html>