[KDE/Mac] Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

[René J.V. Bertin]

> On Sept. 4, 2015, 3:21 p.m., Thomas Lübking wrote:
> > kcontrol/input/mouse.cpp, line 184
> > <https://git.reviewboard.kde.org/r/125043/diff/1/?file=400261#file400261line184>
> >
> >     read this line closely, then fix it ;-P

Oops :) 
But I guess that answers my question whether the change handler is required in the 1st place ... :)


> On Sept. 4, 2015, 3:21 p.m., Thomas Lübking wrote:
> > kcontrol/input/kmousedlg.ui, line 82
> > <https://git.reviewboard.kde.org/r/125043/diff/1/?file=400259#file400259line82>
> >
> >     You *must* ask the i18n team about this (requires an exception) on kde-18n at kde.org
> >     
> >     Since this will have no impact on QTextBrowser (Qt4 or 5) and maybe some other views in either direction, this limited impact needs to be somehow lined out (since to a user there's hardly a difference between QTextBrowser and KTextBrowser)
> 
> Luigi Toscano wrote:
>     kde-workspace 4.14? It's still tracked on our i18n branches, but given that the last release is out (see https://mail.kde.org/pipermail/release-team/2015-August/008835.html), I think we will stop tracking that branch soon. (PS: the list is kde-i18n-doc at kde.org). This is quite dead code at this point...

Well, the limited impact is hinted at by the use of the verb `may` ... Anyway, given the other reactions I'll only bother the i18n team once their opinion becomes the last obstacle to shipping!


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125043/#review84819
-----------------------------------------------------------


On Sept. 4, 2015, 4:22 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125043/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 4:22 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, kde-workspace and kdelibs.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> KDE4 has been providing a setting that (would have) allowed to avoid unwanted text zooming during simulated inertial scrolling (scroll coasting). KDE PIM applications were immune to that issue because certain KDELibs classes use the parameter, which made it all the more annoying that other (e.g. Kate-based) applications weren't. Sadly this setting wasn't published via a GUI.
> 
> This patch adds a checkbox to the input ("mouse") KCM which seemed like the most appropriate place if not only because it also makes sense to provide this KCM on non-X11 platforms like OS X and MS Windows (where settings like "double or single click" are relevant).
> 
> I consider this a fix of an omission bug, but I realise that it could also be considered a new feature, so this RR is also intended to give some public exposure to my patch rather than keeping it to myself.
> 
> 
> Diffs
> -----
> 
>   kcontrol/input/kmousedlg.ui b48a606 
>   kcontrol/input/mouse.h d926a99 
>   kcontrol/input/mouse.cpp cebb174 
> 
> Diff: https://git.reviewboard.kde.org/r/125043/diff/
> 
> 
> Testing
> -------
> 
> For now only on OS X with kdelibs 4.14.11 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150904/36b204b9/attachment-0001.html>