[KDE/Mac] Review Request 125649: [OS X] install icon resources in app bundles where this doesn't happen automatically

René J.V. Bertin rjvbertin at gmail.com
Fri Oct 16 16:28:41 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 16, 2015, 6:28 p.m.)

Review request for Calligra and KDE Software on Mac OS X.

Repository: calligra


Builds on OS X currently generate icons for most Calligra applications, but those are installed only for a happy few (Krita, Braindump and Kexi). The other applications require an explicit install command of the generated `.icns` file into the app bundle's Resources directory.

The attached patch takes care of that.

In addition, it corrects the picture source directories for calligragemini and calligraauthor so those applications can have icons on other platforms too, and replaces the `Q_WS_MACOS` token with the (IMHO) more appropriate `APPLE` token.

Diffs (updated)

  cmake/modules/MacroCalligraAddBenchmark.cmake 9e7e282 
  flow/part/CMakeLists.txt 58882f1 
  gemini/CMakeLists.txt 85123fa 
  karbon/CMakeLists.txt b574779 
  plan/CMakeLists.txt ad39f57 
  plan/workpackage/CMakeLists.txt f6eb20f 
  sheets/CMakeLists.txt b0cc134 
  stage/app/CMakeLists.txt 079bece 
  words/app/CMakeLists.txt 1e73971 
  words/part/CMakeLists.txt 9143176 

Diff: https://git.reviewboard.kde.org/r/125649/diff/


On OS X 10.9 with KDELibs 4.14.12 and MacPorts 2.3.4 .


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151016/815c94b8/attachment.html>

More information about the kde-mac mailing list