[KDE/Mac] Review Request 126186: more sensible workaround for code review crash on OS X

René J.V. Bertin rjvbertin at gmail.com
Fri Nov 27 17:18:41 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Software on Mac OS X and KDevelop.

Repository: kdevplatform


This patch moves the workaround from RR #120081 (commits 1f111414 and 4d2a009c) by calling `setPatch(0)` in the `PatchReviewPlugin` dtor, and using `m_patch->deleteLater()` in `setPatch()` (a change which should probably have been committed).
As a result, the `notifyChange` slot needs a nullptr check, which can then also be used to stop the update timer.


  plugins/patchreview/patchreview.cpp ad576c2 

Diff: https://git.reviewboard.kde.org/r/126186/diff/


On OS X 10.9.5 with KDELibs 4.14.14 and KDevelop 4.7.2 (git/head).


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151127/dec018ca/attachment.html>

More information about the kde-mac mailing list