[KDE/Mac] Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Nov 25 17:18:47 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126170/#review88838
-----------------------------------------------------------
src/kded.cpp (line 683)
<https://git.reviewboard.kde.org/r/126170/#comment60876>
It seems like the function qt_mac_transformProccessToForegroundApplication is doing something along the lines in Qt's OS X QPA.
Maybe you could investigate a bit more into getting Qt to do the right thing?
See qtbase/src/plugins/platforms/cocoa/qcocoaintegration.mm and qcocoahelpers.mm
- Aleix Pol Gonzalez
On Nov. 25, 2015, 6:08 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126170/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 6:08 p.m.)
>
>
> Review request for KDE Software on Mac OS X and KDE Frameworks.
>
>
> Repository: kded
>
>
> Description
> -------
>
> There should be no reason to build `kded5` as an app bundle on OS X, and with recent feedback in mind I postulated that marking it "nongui" (`ecm_mark_nongui_application`) would be acceptable on other platforms too.
>
> Additionally, `kded5` doesn't have any more reason to appear in the Dock or app switcher, on OS X, so I have added the code to make it an agent.
>
>
> Diffs
> -----
>
> CMakeLists.txt 4b9a5ff
> src/CMakeLists.txt 5e95df8
> src/kded.cpp 6929d7d
>
> Diff: https://git.reviewboard.kde.org/r/126170/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5 with Qt 5.5.1 and FWs 5.16.0 .
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151125/120ade72/attachment.html>
More information about the kde-mac
mailing list