[KDE/Mac] Review Request 119844: [OS X] backend improvements for kwallet/Keychain integration

[Valentin Rusu]

* René J.V. Bertin <rjvbertin at gmail.com> [2015-11-06 22:44:30 -0000]:

> 
> 
> > On Nov. 6, 2015, 11:16 p.m., Valentin Rusu wrote:
> > > Ship It!
> 
> Wow, that's a leap of faith ... :)
> 
> I'm working on getting KF5 suitably into MacPorts, progressing 1 framework at a time. I was planning to test these patches (including the latest changes in my other RR; I haven't kept them in sync) and I'll probably only feel comfortable committing them after I have been able to test functionality with something like kwalletmanager (if that one still exists in KF5 form and isn't in a package that won't build on OS X).
> 
> However, I've come to question the whole keychain integration a bit. Apple's keychain API is much poorer than the KWallet API, which means I've had to jump through hoops to implement a reasonably complete OS X Keychain backend. It also means that you cannot access the host's keychain entries from, say, kwalletmanager, and obtain only minimally useful information from KDE's keychains in native applications. In other words, no password sharing. The only advantage I currently see is that keychain wallets can be set to lock when the host is suspended (through a keychain property), which is probably not possible with a pure KDE wallet managed by kwalletd. It was an interesting exercise to write a distributed version of the idle timeout lock feature but in the end I am no longer sure whether it's all worth it.
> I now know how to build "agent" applications that don't show up in the dock or app switcher, so having kwalletd running is no longer going to be an issue.
> 
> To be continued!

Well, good luck and thanks for this. I personnally don't have any
experience nor am I using MAC, so feel free to port/adapt KDE Wallet on
that platform.

> 
> 
> - René J.V.
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119844/#review88112
> -----------------------------------------------------------
> 
> 
> On Sept. 5, 2014, 6:21 p.m., René J.V. Bertin wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/119844/
> > -----------------------------------------------------------
> > 
> > (Updated Sept. 5, 2014, 6:21 p.m.)
> > 
> > 
> > Review request for KDE Software on Mac OS X and Valentin Rusu.
> > 
> > 
> > Repository: kwallet
> > 
> > 
> > Description
> > -------
> > 
> > The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API.
> > 
> > With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. In addition, password prompts no longer get posted somewhere in the background.
> > 
> > 
> > Diffs
> > -----
> > 
> >   src/api/KWallet/CMakeLists.txt 9709559 
> >   src/api/KWallet/kwallet_mac.cpp d93e5ae 
> >   src/api/KWallet/qosxkeychain.h PRE-CREATION 
> >   src/api/KWallet/qosxkeychain.cpp PRE-CREATION 
> >   tests/KWallet/CMakeLists.txt b155f64 
> >   tests/KWallet/kwallettest.cpp 3351a6b 
> > 
> > Diff: https://git.reviewboard.kde.org/r/119844/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > Testing and development of these was done on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment (https://trac.macports.org/ticket/44473). Since I am not currently able to build (parts of) KF5, porting of my modifications to KF5/KWallet has been done in source only. However, I have good hope that there will be little bugs to review in this request, given the lack of non-esthetic (formatting) modifications to the current kwallet_mac.cpp and kwallettest.cpp.
> > 
> > 
> > Thanks,
> > 
> > René J.V. Bertin
> > 
> >
> 

-- 
Valentin Rusu
IRC: valir