[KDE/Mac] Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 11:03 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
-------

Code cleaned up.

In reaction to my message on the kde-frameworks ML ("KIdleTime : provide a settable resolution for the polling backends?"), I've added a prototype implementation of a mechanism to set the poller timer resolution. That resolution is directly relevant for my implementation, which is why I didn't present it in a separate RR.


Repository: kidletime


Description
-------

I noticed that the KIdleTime example doesn't work properly on OS X, and that the plugin for OS X still uses the deprecated Carbon-based algorithm that I already patched for KDE4.

This patch is a work-in-progress (hence the qDebugs) update to use IOKit, IORegistry and CoreServices to do idle-time calculation as it should be done, and allow simulated user activity through a "less deprecated" function.


Diffs (updated)
-----

  src/plugins/osx/CMakeLists.txt e1b50b8 
  src/plugins/osx/macpoller.h ef51ea5 
  src/plugins/osx/macpoller.cpp ad9c10f 

Diff: https://git.reviewboard.kde.org/r/126078/diff/


Testing
-------

On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .

The example now works: when I set a QTimer with interval==0, the expected wait for user input (`resumingFromIdle` signal) works. However, I am getting a `stopCatchingIdleEvents` signal which means the application waits forever, without ever getting to compare idle time to the list of timeouts.
I haven't been able to figure out where that signal comes from, nor why this doesn't happen on Linux.

Surely I'm missing something, but what?


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151116/2128c3bd/attachment.html>