[KDE/Mac] Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126069/#review88366
-----------------------------------------------------------



src/runtime/kwallet-query/src/CMakeLists.txt (line 20)
<https://git.reviewboard.kde.org/r/126069/#comment60584>

    Why only for APPLE?


I wouldn't add if(APPLE) unless there's something very specific about the platform.

- Aleix Pol Gonzalez


On Nov. 14, 2015, 10:29 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126069/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 10:29 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Pending an overdue update to my OS X Keychain backend, this patch provides better integration of the runtime:
> 
> - kwallet-query and kwalletd5 are built as regular executables, not app bundles, making them easier to find via the shell and KService
> - kwalletd5 is modified to run as an agent, meaning it doesn't show up in the Dock or App Switcher.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwallet-query/src/CMakeLists.txt 9ab9d9d 
>   src/runtime/kwalletd/CMakeLists.txt ba9e7ba 
>   src/runtime/kwalletd/main.cpp dd959b6 
> 
> Diff: https://git.reviewboard.kde.org/r/126069/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9 with Qt 5.5.0, in the 5.15.0 frameworks release version.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151114/6fd81368/attachment.html>