[KDE/Mac] Review Request 123595: Fix KUser test for Mac.

Alex Richardson arichardson.kde at gmail.com
Sun May 10 22:56:18 UTC 2015



> On May 6, 2015, 5:40 p.m., René J.V. Bertin wrote:
> > I'm not sure, after reading http://pig.made-it.com/uidgid.html
> > 
> > also:
> > 
> > ```
> > > id nobody
> > uid=4294967294(nobody) gid=4294967294(nobody) groups=4294967294(nobody),12(everyone),61(localaccounts),402(com.apple.sharepoint.group.1),403(com.apple.sharepoint.group.2),100(_lpoperator)
> > ```
> > 
> > and
> > 
> > ```
> > > id unknown
> > uid=99(_unknown) gid=99(_unknown) groups=99(_unknown),402(com.apple.sharepoint.group.1),12(everyone),61(localaccounts),403(com.apple.sharepoint.group.2),100(_lpoperator)
> > ```
> 
> David Faure wrote:
>     "nobody" is a special user, let's put that one aside since the unittest doesn't need it.
>     
>     I'm not sure `id` works like the APIs KUser uses. What does the unittest say for you, in fact? (with or without my patch, doesn't matter for debugging this)
> 
> René J.V. Bertin wrote:
>     I certainly hope that KUser agrees with `id` ...
>     
>     Sorry I can't answer your question, I haven't been touching KF5 at all until now.

KUser just uses the stanard `getpwuid(3)`/`getpwnam(3)` function which AFAIK will also be used by `id`.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123595/#review79976
-----------------------------------------------------------


On May 6, 2015, 5:08 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123595/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 5:08 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks and Marko Käning.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> According to CI [1], an invalid user belongs to "nogroup" on Mac.
> Not sure if this is true on all OSX installations though?
> 
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/19/testReport/%28root%29/TestSuite/kusertest/
> 
> 
> Diffs
> -----
> 
>   autotests/kusertest.cpp d17a2d3e97d5056524281eb18766377e48a0da35 
> 
> Diff: https://git.reviewboard.kde.org/r/123595/diff/
> 
> 
> Testing
> -------
> 
> Still passes on Linux; should fix the CI for mac, AFAICS.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150510/0c414386/attachment-0001.html>


More information about the kde-mac mailing list