[KDE/Mac] Review Request 124185: Improved Python macros for CMake

[Marko Käning]

Hi René and all,

it seems like having such a FindPython cmake macro is generally a good idea
and should perhaps even get introduced in ECM?

There are certainly more projects which would be happier, if CMake could take
care of locating all Python versions available on a given system.

Greets,
Marko



On 26 Jun 2015, at 13:16 , René J.V. Bertin <rjvbertin at gmail.com> wrote:

> 
> This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124185/
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> By René J.V. Bertin.
> Repository: kdev-python
> Description
> 
> CMake's default macros for finding Python (PythonInterp and PythonLibs) do not do a great job across all platforms at finding an exact Python version, at least not when multiple versions are available and esp. not if the desired version is not the default version.
> This patch proposes to use another set of macros, modified from OMPL (https://bitbucket.org/ompl/ompl/src/tip/CMakeModules/FindPython.cmake) that should conform better to the requirements.
> The original FindPython.cmake file is covered by a BSD license; the (or one of its) author made me aware of its existence himself.
> Testing
> 
> For now, only on OS X 10.9.5 under MacPorts with multiple Python versions installed.
> I have not changed the Python version acceptance logic beyond correcting the check of the PYTHON_FOUND boolean.
> Diffs
> 
> CMakeLists.txt (18ecfc0)
> cmake/modules/FindPython.cmake (PRE-CREATION)
> parser/CMakeLists.txt (2ac78fc)
> View Diff
> 
> _______________________________________________
> kde-mac at kde.org
> List Information: https://mail.kde.org/mailman/listinfo/kde-mac
> KDE/Mac Information: http://community.kde.org/Mac

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150626/609be6e1/attachment.html>