[KDE/Mac] Cross-platform with kdeinit5, klauncher5, kded5 and friends

[Jeremy Whiting]

On Fri, Jan 30, 2015 at 5:58 PM, René J.V. <rjvbertin at gmail.com> wrote:

> On Friday January 30 2015 16:34:51 Jeremy Whiting wrote:
>
> Hi Jeremy,
>
> > Ok, I took a deep look inside kbuildsycoca5 today. I ran Instruments on
> it
> > and found as Marko already pointed out most of the time spent in there is
> > delving deep into /Applications subfolders. I'm not sure exactly what
> it's
> > looking for, mostly .desktop files from what I saw, but it's not finding
>
> No leaves? ;)
>
> Have you tried to figure out *why* it's looking in there? Is that a
> regression introduced by our QSP patch, or is it because we keep standard
> locations where it shouldn't be searching?
> Do we know why this isn't an issue with kbuildsycoca4?
>

I believe it's because kbuildsycoca4 looks using kstandarddirs, not QSP,
QSP ApplicationsPath is /Applications on osx, while it's
/usr/share/applications, /usr/local/share/applications and
~/.local/share/applications on linux. Maybe we should make it look in
$PREFIX/share/applications since .desktop files aren't installed into
/Applications anyway. macports is putting those into
/opt/local/share/applications, kdesrc-build with /usr/local as prefix is
doing likewise into that prefix. I.e. having kbuildsycoca5 look in QSP
ApplicationsPath on osx is ridiculous, it will never contain .desktop
files. If we do that the check for .isBundle() isn't as important since
macports/homebrew/fink and kdesrc-build aren't putting .app files into
$PREFIX/share/applications anyway... So what's a good way to get
$PREFIX/share/applications on osx, QSP isn't it :/


> > any. Traversing the whole tree is time consuming though, and we know it's
> > not likely to find .desktop files inside any .app bundles, so I added the
> > attached patch and that sped up both kbuildsycoca5 itself (running from
> the
> > terminal manually) as well as makes kded5 responsive from what I can
> tell.
>
> Sped up how much?
> Regardless of where it looks, if the time spent searching remains an issue
> we could consider tapping into SpotLight to find the files.
>

Using spotlight isn't a bad idea tbh, but it's orders of magnitude faster
to skip bundles. KBuildSycoca5 took minutes before this change, seconds
after this change (but probably isn't very useful since it's not actually
finding the .desktop files.

thanks,
Jeremy

>
> R.
> _______________________________________________
> kde-mac at kde.org
> List Information: https://mail.kde.org/mailman/listinfo/kde-mac
> KDE/Mac Information: http://community.kde.org/Mac
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150130/285e9bd4/attachment.html>