[KDE/Mac] Review Request 122277: Improve the version (and copyright) information display in KDE/KF5 systemsettings
René J.V. Bertin
rjvbertin at gmail.com
Tue Jan 27 20:02:27 UTC 2015
> On Jan. 27, 2015, 6:30 p.m., Yichao Yu wrote:
> > qt4/config/qtcurveconfig.cpp, line 235
> > <https://git.reviewboard.kde.org/r/122277/diff/1/?file=345383#file345383line235>
> >
> > My first commit comes in 2013 according to the git log.
> >
> > Not sure if this is the right place (or what is the right place for other contributors) but feel free to add yourself to the AUTHORS file
>
> Yichao Yu wrote:
> Actually nvm for the AUTHORS file, just updated with `git log`
That's not a list in any logical order of frequency of contribution, is it?
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122277/#review74836
-----------------------------------------------------------
On Jan. 27, 2015, 6:21 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122277/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 6:21 p.m.)
>
>
> Review request for KDE Software on Mac OS X and Yichao Yu.
>
>
> Repository: qtcurve
>
>
> Description
> -------
>
> Configuring QtCurve through the KDE systemsettings application shows version and copyright information that isn't very informative nor up to date.
>
> This patch appends the git commit tag to the version when building in a git working copy, and also adds the name of the current (main) developer to give credit where credit is due!
>
>
> Diffs
> -----
>
> qt4/config/qtcurveconfig.cpp f3e010c
> qt5/config/qtcurveconfig.cpp 5871ac5
> CMakeLists.txt 9bc4c3d
>
> Diff: https://git.reviewboard.kde.org/r/122277/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5 against Qt4/KDE (4.14.4), Qt 5.4.0 and GTk2 (all through MacPorts).
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150127/57b92feb/attachment.html>
More information about the kde-mac
mailing list