[KDE/Mac] OSX/CI: Uses of outdated Q_WS_MAC in KF5 projects

Kurt Hindenburg kurt.hindenburg at gmail.com
Wed Jan 21 15:51:36 UTC 2015


> On Jan 21, 2015, at 4:16 AM, Marko Käning <mk-lists at email.de> wrote:
> 
> So, this is the KF5 fodder I’ve spotted so far:
> ---
> /Users/marko/WC/KDECI-builds/kf5-qt5/knotifications/src/knotificationmanager.cpp:    #ifndef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/konsole/src/Application.cpp:#if defined(Q_WS_MAC)
> /Users/marko/WC/KDECI-builds/kf5-qt5/ktexteditor/src/view/kateviewinternal.cpp:#ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/lokalize/src/lokalizemainwindow.cpp:#ifndef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/marble/src/apps/marble-kde/marble_part.cpp:    #ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/marble/src/lib/marble/QtMarbleConfigDialog.cpp:    #ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/plasma-workspace/kglobalaccel/globalshortcutsregistry.cpp:#elif defined(Q_WS_MACX)
> /Users/marko/WC/KDECI-builds/kf5-qt5/plasma-workspace/kglobalaccel/kglobalaccel_mac.cpp:#ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/plasma-workspace/kglobalaccel/kglobalaccel_mac.cpp:#endif // !Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/predicate/Predicate/Tools/Utils.cpp:#ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/predicate/Predicate/Tools/Utils.cpp:#ifdef Q_WS_MAC
> ---
> This all needs fixing! Feel free to go for it! ;-)
> 
Which are we using? 

Q_OS_MAC is defined when you are on an Apple Darwin-based system such OS X or iOS.
Q_OS_OSX is defined when you are on an OS X system.
http://doc.qt.io/qt-5/osx-issues.html <http://doc.qt.io/qt-5/osx-issues.html>

Kurt


> But I am off for now.
> _______________________________________________
> kde-mac at kde.org
> List Information: https://mail.kde.org/mailman/listinfo/kde-mac
> KDE/Mac Information: http://community.kde.org/Mac

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150121/620e715c/attachment.html>


More information about the kde-mac mailing list