[KDE/Mac] Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

[René J.V. Bertin]

> On Jan. 20, 2015, 9:12 p.m., Friedrich W. H. Kossebau wrote:
> > cmake/modules/FindPqxx.cmake, line 15
> > <https://git.reviewboard.kde.org/r/122114/diff/4/?file=343891#file343891line15>
> >
> >     Given FIND_PACKAGE_HANDLE_STANDARD_ARGS below this should not be needed (also would need to ifdef on _FOUND if). So propose to remove it.
> >     
> >     Hm, where is `FindPqxx.cmake` actually used from? I see `kexi/CMakeLists.txt` has a lot of PQXX searching inline, but nowhere a `find_package(PQXX)` or similar.

Good question, one I've asked myself... I cannot even affirm anymore that I needed the //opt//local// mod to let pqxx be found.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122114/#review74432
-----------------------------------------------------------


On Jan. 20, 2015, 8:42 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122114/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 8:42 p.m.)
> 
> 
> Review request for Calligra and KDE Software on Mac OS X.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch adapts the build system to OS X with KDE4, Qt4 and other dependencies installed through MacPorts. 
> 
> In order of appearance in the patch file:
> - `-DQT_EXCEPTIONS`: this is for use with Qt built with its -no-exceptions option, which MacPorts provides as an optional variant.
> - Newer OS X variants only provide the clang compiler
> - The default install location for MacPorts is `/opt/local`, but this can be changed by the user. The header and library search paths required for OpenJPEG, libpqxx and OpenVC are added using `//opt//local//` which is of course equivalent to `/opt/local` but easier to search-and-replace with the true install location in MacPorts' post-patch stage.
> - the product set for OS X has been extended to all applications and features that build and make sense. (Calligra Gemini builds, but does not function properly.)
> 
> A "Portfile" and accompanying patches that don't have the vocation to be included "upstream" in calligra will be uploaded to MacPorts' trac system soon.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt facb5f9 
>   cmake/modules/FindOpenJPEG.cmake 6bfd93c 
>   cmake/modules/FindPqxx.cmake 3e24a0c 
>   cmake/modules/FindVc.cmake bb9823f 
>   cmake/productsets/osx.cmake 1fe8f1c 
> 
> Diff: https://git.reviewboard.kde.org/r/122114/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with kdelibs 4.14.4 and Qt 4.8.6 installed through MacPorts.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150120/26b55ce0/attachment.html>