[KDE/Mac] Review Request 121960: Support an infix for libqtcurve-utils so different versions can co-exist for GTk2, Qt4 and Qt5 support

[Yichao Yu]

> On 一月 19, 2015, 8:22 a.m., Harald Sitter wrote:
> > are you sure this patch was actually complete? because it most certainly does not work as is.
> > 
> > http://build.kde.org/job/qtcurve_master_qt5/10/console
> > 
> > qtc_option just like the basic cmake version option() is a boolean switch. what you need is 
> > 
> >     set(QTC_UTILSLIB_INFIX "" CACHE STRING "an infix argument to have different qtcurve-utils libraries")
> > 
> > otherwise what happens is OUTPUT_NAME "qtcurve-utilsON" respectively "qtcurve-utilsOFF"
> 
> Harald Sitter wrote:
>     I pushed that change for now in the hopes that it fixes the CI builds. Please have a look and make sure qtcurve now does what was originally intended by this RR.

Please revert.

qtc_option is not like option (not intended to) I've fixed the typo and it should be fine now.


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121960/#review74319
-----------------------------------------------------------


On 一月 10, 2015, 10:16 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121960/
> -----------------------------------------------------------
> 
> (Updated 一月 10, 2015, 10:16 a.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> When building separate QtCurve packages for independent GTk2, Qt4/KDE4 and Qt5/KF5 versions of the style, a conflict arises with libqtcurve-utils. Each of the three versions uses this library, and it needs to be linked with the rendering SDK itself.
> 
> This patch introduces a CMake infix option, `QTC_UTILSLIB_INFIX` that can be used to change the library name to something unique for each package. When the option is not defined, the current behaviour is preserved; this is the default.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e8dd723 
>   lib/utils/CMakeLists.txt 0dd71c1 
> 
> Diff: https://git.reviewboard.kde.org/r/121960/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with Qt4.8/kdelibs 4.14.4 (using libqtcurve-utils-qt4.dylib), GTk2/X11 (libqtcurve-utils-gtk2.dylib) and "pure" Qt 5.3.2 (libqtcurve-utils-qt5.dylib).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150119/07b79b42/attachment.html>