[KDE/Mac] QStandardPaths possible solution
iandw.au at gmail.com
Sat Jan 10 05:13:03 UTC 2015
On 10/01/2015, at 2:38 PM, Jeremy Whiting wrote:
> https://codereview.qt-project.org/#/c/103277/ In case anyone wants to follow along that I didn't already add as reviewers.
That looks great, Jeremy!!! … :-)
I am struggling to catch up with this thread, but I don't need to be added to
the Gerrit pages as a reviewer.
However, I do have some reservations, which I think I should air here.
1) Should an XDG path be mandatory in every Qt-Mac 5 installation?
I do not think so. Perhaps the path computed could be given a
one-time existence check and skipped over if it does not exist.
2) Will it always be the case that installers (e.g. in MacPorts) will use
the same prefix for Qt libraries and KF5 or other XDG-based apps?
I am not convinced of that, but I appreciate that there was difficulty
finding a prefix that would be visible at Qt-Mac 5 installation time.
3) If an XDG path exists, then I think it should be searched *before*
the standard Apple OS X paths (for efficiency), but not before the
writable paths, which QSP prepends anyway. So I think the last
chunk should move to just after lines 188-189 in the original code
(or 243-244 in the patched code), i.e. just after "QStringList dirs;".
4) Do we need a documentation change in qstandardpaths.cpp? I
think so, but maybe Qt has technical writers to take care of that,
or maybe there is a "string freeze" happening. If you would like
some words, I sent some in an attachment 48 hours ago. They
could easily be edited to remove the references to <APPROOT>,
which David did not support.
All the best, Ian W.
More information about the kde-mac