[KDE/Mac] Review Request 121960: Support an infix for libqtcurve-utils so different versions can co-exist for GTk2, Qt4 and Qt5 support

René J.V. Bertin rjvbertin at gmail.com
Fri Jan 9 20:14:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121960/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X and Yichao Yu.


Repository: qtcurve


Description
-------

When building separate QtCurve packages for independent GTk2, Qt4/KDE4 and Qt5/KF5 versions of the style, a conflict arises with libqtcurve-utils. Each of the three versions uses this library, and it needs to be linked with the rendering SDK itself.

This patch introduces a CMake infix option, `QTC_UTILSLIB_INFIX` that can be used to change the library name to something unique for each package. When the option is not defined, the current behaviour is preserved; this is the default.


Diffs
-----

  CMakeLists.txt e8dd723 
  gtk2/style/CMakeLists.txt 451ecdd 
  lib/cairo/CMakeLists.txt 3363e46 
  lib/utils/CMakeLists.txt 0dd71c1 
  qt4/config/CMakeLists.txt 3b65e09 
  qt4/kwin/CMakeLists.txt 52c7c03 
  qt4/kwinconfig/CMakeLists.txt 1de6dc2 
  qt4/style/CMakeLists.txt 4ac461f 
  qt5/config/CMakeLists.txt b4184dd 
  qt5/kwin/CMakeLists.txt 52c7c03 
  qt5/kwinconfig/CMakeLists.txt 1de6dc2 
  qt5/style/CMakeLists.txt c78a73d 
  test/CMakeLists.txt 007c595 

Diff: https://git.reviewboard.kde.org/r/121960/diff/


Testing
-------

On OS X 10.9.5 with Qt4.8/kdelibs 4.14.4 (using libqtcurve-utils-qt4.dylib), GTk2/X11 (libqtcurve-utils-gtk2.dylib) and "pure" Qt 5.3.2 (libqtcurve-utils-qt5.dylib).


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150109/4aa2990f/attachment.html>


More information about the kde-mac mailing list