[KDE/Mac] Review Request 121930: [OS X] improvements to KSharedData

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121930/#review73521
-----------------------------------------------------------

Ship it!


personally, I also think that if you tested and it works, and Allan has no objections, that you can go ahead and push this. but please don't comment out code, just remove it.


kdecore/util/kshareddatacache_p.h
<https://git.reviewboard.kde.org/r/121930/#comment51185>

    remove dead code


- Milian Wolff


On Jan. 8, 2015, 5:09 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121930/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 5:09 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, kdelibs and Allen Winter.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch improves KSharedData on 2 points:
> 
> - It enables `KSDC_THREAD_PROCESS_SHARED_SUPPORTED` on OS X because even if the OS cannot do timeouts on mutex locking, it does have Posix mutexes (pthreads). I don't know why this was deactivated explicitly on OS X (do you remember, Allan?), but haven't seen issues with KSDC_THREAD_PROCESS_SHARED_SUPPORTED - for now.
> 
> - OS X doesn't have `posix_fallocate()`, but an emulation of this function is available in the Mozilla code (reference found on StackOverflow). The code seems to be license-compatible, so I removed the code for non-OS X platforms, and include it in `kshareddatacache_p.h`. Again, this seems to work.
> 
> 
> Diffs
> -----
> 
>   kdecore/util/kshareddatacache_p.h 931de4d 
>   kdecore/util/posix_fallocate_mac.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121930/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with kdelibs 4.14.4 and KDE PIM 4.13.3 (I use KMail as my default MUA).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150108/68c22eb4/attachment.html>