[KDE/Mac] Review Request 122563: [OS X] emulate native window settings restore (size and position)

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122563/
-----------------------------------------------------------

(Updated Feb. 13, 2015, 8:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Software on Mac OS X and kdelibs.


Repository: kdelibs


Description
-------

OS X applications usually remember the last used screen, size and screen position across restarts, and do not save screen-resolution dependent settings. 

The patch proposed here emulates that behaviour by following the example given in the documentation for `QWidget::saveGeometry`: the current geometry is saved in a key called `geometry`, and position is kept up to date by letting `QEvent::Move` dirty the size setting, as under MS Windows.

I think it's good practice to support previously stored settings when changing a config store, so the code attempts to restore "legacy" settings when the new key is unavailable.


Diffs
-----

  kdeui/widgets/kmainwindow.cpp 85beacc 

Diff: https://git.reviewboard.kde.org/r/122563/diff/


Testing
-------

On OS X 10.9.5 with Qt 4.8.6 and kdelibs 4.14.5 (head of the 4.14 branch); tested with systemsettings, kate and kontact.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150213/658e066f/attachment-0001.html>