[KDE/Mac] Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

René J.V. Bertin rjvbertin at gmail.com
Fri Dec 25 21:14:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126170/
-----------------------------------------------------------

(Updated Dec. 25, 2015, 10:14 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
-------

This takes the patch back to my original proposition, because of my previous comment (avoid unheriting `QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM`).

There is one additional minor modification: `KDE_FULL_SESSION` has no special meaning on OS X. Advanced users might set it however, to unblock certain functionality elsewhere. Shunting kde_running to false means `kdeinit5` can be started through `kded5` regardless of whether `KDE_FULL_SESSION` is set; `kded5` is a "logical" utility to start in order to bootstrap the KDE runtime infrastructure (e.g. via a launchd plist).


Repository: kded


Description
-------

There should be no reason to build `kded5` as an app bundle on OS X, and with recent feedback in mind I postulated that marking it "nongui" (`ecm_mark_nongui_application`) would be acceptable on other platforms too.

Additionally, `kded5` doesn't have any more reason to appear in the Dock or app switcher, on OS X, so I have added the code to make it an agent.


Diffs (updated)
-----

  src/CMakeLists.txt 5e95df8 
  src/kded.cpp c7fdfee 

Diff: https://git.reviewboard.kde.org/r/126170/diff/


Testing
-------

On OS X 10.9.5 with Qt 5.5.1 and FWs 5.16.0 .


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151225/c9bc6df5/attachment.html>


More information about the kde-mac mailing list