[KDE/Mac] Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

[Martin Klapetek]

> On Dec. 16, 2015, 5:40 p.m., Martin Klapetek wrote:
> > src/kstatusnotifieritem.cpp, line 710
> > <https://git.reviewboard.kde.org/r/126369/diff/1/?file=422842#file422842line710>
> >
> >     Why is it reasonable if the platform guidelines speak against it?
> 
> René J.V. Bertin wrote:
>     The platform guidelines apply to regular application menus and displaying an icon that corresponds to the item action; but even there they are guidelines. They shouldn't be mistaken for hard rules.
>     Menus in the notification area often show other kinds of widgets, use different font/weights or even provide a window that contains a view on a website. There's a utility that shows the mobile version of one's FB or G+ account - and that little gimmick is available through the App Store. Meaning Apple vetted it; they in fact show icons themselves in the input selection menu.
>     
>     The reason why I find it useful to show the `app->windowIcon()` here is because often the systray icon and menu are the only interface an application provides. It is thus good to show the information the user is used to seeing when identifying applications; Finder, Dock and App Switcher all show the application icon plus the application name.
>     
>     Any other items in the systray menu ought to be subject to the ShowIconsInMenus preference which is supposed to be false by default. (With "ought to be" I mean that I don't see anything in the code suggesting they'll behave otherwise.)

I think a shorter version of this^ should be in the code instead of that comment ;)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126369/#review89608
-----------------------------------------------------------


On Dec. 16, 2015, 10:24 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126369/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 10:24 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> OS X has a number of limitations in features used by KNotifications, notably concerning the status notifier item (aka system tray icon).
> 
> This RR will likely evolve to address multiple limitations (at least also the NeedsAttention state); at the moment it only proposes an emulation of `QMenu::addSection`.
> 
> `QMenu::addSection` works by adding a QAction with a "texted separator" at the insertion location. Texted separators do not exist in menu items in the OS X "global" menubar (they become regular separators), and Qt will not provide a platform-specific implementation. Loss of the section title text is maybe not always an issue, but I think it is in the system tray menu. I therefore propose to emulate `QMenu::addSection` by replacing the texted separator with an inactive (disabled) menu item that shows the text, followed by a standard separator. Menus in the notification area are much less subject to interface guidelines, so the presence of an item icon is acceptable and IMO useful for the `titleAction`.
> 
> Testing the NeedsAttention state with the tests/kstatusnotifieritemtest application leads to disappearance of the menubar icon, i.e. the access to the notifier menu becomes invisible rather than blinking (which is what I get on Linux using the same packaging). Adding a few qDebug statements shows that the `attentionIcon` is empty.
> I'd appreciate a crash course how this feature is supposed to work, so I can see if an OS X implementation might be feasible.
> 
> 
> Diffs
> -----
> 
>   src/kstatusnotifieritem.cpp f9bf460 
> 
> Diff: https://git.reviewboard.kde.org/r/126369/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.17.0 .
> 
> 
> File Attachments
> ----------------
> 
> the systray icon & menu created by kstatusnotifieritemtest . This application has no icon to show.
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/286037ae-07b3-454a-a226-1748854493a1__kstatusnotifieritemtest-systray.png
> The systray icon and menu created by the KDE4 kwalletmanager (code has an equivalent patch)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/4fc9d4e4-1537-478c-9196-94cbc17b6b7c__kwalletmanager-systray.png
> An Apple systray icon+menu that shows icons (which cannot be hidden)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fc48a963-2e18-4396-bd38-062d41688118__Apple-systray-menu-with-icons.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151216/de6ca432/attachment.html>