[KDE/Mac] Review Request 126241: [OS X] adapting KStyle (WIP)

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126241/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X, KDE Frameworks and Hugo Pereira Da Costa.


Repository: frameworkintegration


Description
-------

This is a split-off from RR https://git.reviewboard.kde.org/r/126198/, as suggested there.

The proposed change (which is a work in progress) contains a few modifications mirroring those proposed for the KdePlatformTheme plugin, aiming to adapt the library to Mac OS X.

These modifications should probably be implemented by subclassing KStyle rather than duplicating all code.

I have been focussing on the platform theme modifications, without really looking into the extent to which KStyle is used or potentially useful on OS X. A separate RR should support discussion about that more easily.

Would it for instance be possible to use KStyle to create a Qt *style* plugin that does nothing more than extending the native theme/style with support for KDE's font roles/types, colour palettes and icon themes? This could be preferable for users or developers who are not interested in providing a consistent cross-platform look (which presumable requires a platform *theme*) and/or who do not want to depend on a theme that makes explicit use of a private Qt API (cf. `KdeMacTheme` in the RR above).


Diffs
-----

  src/kstyle/CMakeLists.txt bc26667 
  src/kstyle/kstyle.mm PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126241/diff/


Testing
-------

Builds on OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 ; "source" modifications are tested in the platform theme.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151204/c76cf663/attachment.html>