[KDE/Mac] Review Request 124894: [OS X] make it build

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124894/#review84235
-----------------------------------------------------------


I think the linker errors you're seeing should better be solved at the CMakeLists.txt level, it looks like for some reason some of the internal symbols are not found for some of the tests, it's likely that the link list for those is missing a couple of modules.


src/akonadi/akonadiserializer.cpp (lines 351 - 374)
<https://git.reviewboard.kde.org/r/124894/#comment58330>

    Hm, isn't it simply that #include <numeric> is missing in this file? I'd rather have that than a non-STL implementation of accumulate in there.



tests/units/akonadi/CMakeLists.txt (line 9)
<https://git.reviewboard.kde.org/r/124894/#comment58331>

    Only difference here is the missing akonadidatasourcequeriestest, any idea why you had to remove it? I'd prefer a proper fix to such a workaround.



tests/units/domain/CMakeLists.txt (line 2)
<https://git.reviewboard.kde.org/r/124894/#comment58332>

    Same thing here, what's wrong with the two tests you disabled?



tests/units/presentation/CMakeLists.txt (line 2)
<https://git.reviewboard.kde.org/r/124894/#comment58333>

    Ditto, I'd rather have proper fixes.



tests/units/widgets/CMakeLists.txt (line 2)
<https://git.reviewboard.kde.org/r/124894/#comment58334>

    And same here of course.


- Kevin Ottens


On Aug. 23, 2015, 5:55 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124894/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2015, 5:55 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Zanshin.
> 
> 
> Repository: zanshin
> 
> 
> Description
> -------
> 
> This is a set of patches that allow zanshin version `0.2.1-1163-gbf5c321` to build on OS X against the git head (or almost head) of kdelibs 4.14 and kdepim* 4.14 .
> I presume for now that a number of changes are self-explanatory (for instance, `zanshinkdepimstatic` calls itself static, isn't installed and doesn't export any symbols explicitly so all points to it being intended to be a static instead of a shared lib).
> The patches that disable a number of tests, and I do not understand myself what exactly goes wrong without them other than that the linker gives errors like
> 
> ```
> # Undefined symbols for architecture x86_64:
> #   "decltype(*(std::__1::forward<QSharedPointer<Domain::QueryResult<QString> > >(fp0)).*fp(std::__1::forward<>(fp1))) std::__1::__invoke<QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*&)() const, QSharedPointer<Domain::QueryResult<QString> >, void>(QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*&&&)() const, QSharedPointer<Domain::QueryResult<QString> >&&)", referenced from:
> #       std::__1::__function::__func<std::__1::__mem_fn<QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*)() const>, std::__1::allocator<std::__1::__mem_fn<QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*)() const> >, QList<std::__1::function<void (QString, int)> > (QSharedPointer<Domain::QueryResult<QString> >)>::operator()(QSharedPointer<Domain::QueryResult<QString> >&&) in queryresulttest.o
> # ld: symbol(s) not found for architecture x86_64
> # clang: error: linker command failed with exit code 1 (use -v to see invocation)
> ```
> 
> Possibly a comparable to the reason why I had to define the `std::accumulate` functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/kdepim/libkdepim/CMakeLists.txt cc8845a 
>   3rdparty/kdepim/libkdepim/tests/CMakeLists.txt 775ac0e 
>   src/akonadi/akonadiserializer.cpp 5116fa5 
>   tests/units/akonadi/CMakeLists.txt 15e887f 
>   tests/units/domain/CMakeLists.txt 3b4d23c 
>   tests/units/presentation/CMakeLists.txt 3ce5a70 
>   tests/units/widgets/CMakeLists.txt ab740a3 
> 
> Diff: https://git.reviewboard.kde.org/r/124894/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with the system compiler (`Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)`)
> 
> My initial reason to install this was to "check it out" and learn how to use it, so I have not done any further testing ...
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150823/d31c7db0/attachment-0001.html>