[KDE/Mac] Review Request 120649: Encode the URIs which end up in DTD files

[Marko Käning]

> On Oct. 24, 2014, 12:05 a.m., Marko Käning wrote:
> > I will have to test this in a specially configured OSX/CI VM. Will report back on it.

Herewith I can report, that on Scarlett's new CI system we were able to verify that the file ```/opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kdelibs4support/inst/Library/Application\ Support/kf5/kdoctools/customization/dtd/kdex.dtd``` correctly contained the escaped space in ```"Application Support"```!


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120649/#review69058
-----------------------------------------------------------


On Feb. 28, 2015, 11:05 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120649/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2015, 11:05 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
> 
> The function is duplicated from the matching functions in kdoctools
> because:
> - this module will go away in the not far future;
> - the function is not generic enough to be used outside (yet)
> 
> See also https://git.reviewboard.kde.org/r/120648/ for the twin review on kdoctools.
> 
> 
> Diffs
> -----
> 
>   cmake/uriencode.cmake PRE-CREATION 
>   src/CMakeLists.txt 4a1d80d 
> 
> Diff: https://git.reviewboard.kde.org/r/120649/diff/
> 
> 
> Testing
> -------
> 
> It compiles, but I can't properly test Mac and Windows scenarios
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150412/06a12e35/attachment-0001.html>