[KDE/Mac] Review Request 120150: [OS X] prevent another crash after finishing a code difference review

René J.V. Bertin rjvbertin at gmail.com
Mon Sep 29 13:01:35 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 29, 2014, 3:01 p.m.)


This change has been discarded.

Review request for KDE Software on Mac OS X, KDevelop and Olivier Goffart.

Repository: kdevplatform


In https://reviewboard.kde.org/r/120081/ I proposed an (accepted) approach to prevent kdevelop from crashing after closing the patch review ("git/show differences") toolview. I had another of those crashes after heavier-than-usual perusal of the toolview, despite the previous patch. The attached patch replaces all `delete`s of `QObject` derived class instances with `deleteLater()`.


  plugins/patchreview/patchreview.cpp 18b63db 

Diff: https://git.reviewboard.kde.org/r/120150/diff/


kdevplatform git/kde4-legacy on KDE/MacPorts OS X 10.6.8 . 


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140929/9da86f35/attachment.html>

More information about the kde-mac mailing list