[KDE/Mac] Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120355/
-----------------------------------------------------------

(Updated Sept. 26, 2014, 7:28 p.m.)


Review request for KDE Base Apps, KDE Software on Mac OS X, kdelibs, and Qt KDE.


Changes
-------

Indeed, adding a simple check against q->parentWidget() in QWidgetPrivate::setGeometry_sys_helper helps prevent the application crash when the `KMenu::addTitle` is called. That's good and well, but the end result is that the added title doesn't appear at all. Compare the 1st screenshot with the 2nd (in which the addTitle emulation under review here is active).


Repository: kde-baseapps


Description
-------

Mac OS X cannot handle the formatting used for title menu items when it applies to items in the toplevel menu bar. An application calling KMenu::addTitle on such a menu item will crash immediately, somewhere deep in Qt.

This patch works around that crash by emulating the addTitle effect.

Curiously, the addTitle call that causes the crash when clicking on the Help menu concerns a submenu of an item of the Tools menu...


Diffs
-----

  konq-plugins/uachanger/uachangerplugin.cpp 5e2d094 

Diff: https://git.reviewboard.kde.org/r/120355/diff/


Testing
-------

OS X 10.6.8 with kdelibs 4.14.1


File Attachments (updated)
----------------

patch for qwidget_mac.mm
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/26/b5c2dd92-33db-4225-9750-d10e13f0f835__prevent_addTitleRelated_crash.patch
with the Qt patch
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/26/96f4fbfa-854e-4596-9f5f-d82f98a06955__Screen_shot_2014-09-26_at_19.16.20.png
with the addTitle emulation patch
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/26/5ddf4a63-b3bb-415a-815a-c06eb7a5c7f2__Screen_shot_2014-09-26_at_19.19.40.png


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140926/c6f432b5/attachment.html>