[KDE/Mac] Review Request 120287: [OS X] make kde-workspace build

[Thomas Lübking]

> On Sept. 19, 2014, 6:40 nachm., Thomas Lübking wrote:
> > kcontrol/krdb/krdb.cpp, line 581
> > <https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line581>
> >
> >     Xlib call?
> >     
> >     Why do you "need" krdb at all?
> >     (gtk+ & Qt should align to OSX anyway and you're skipping xrdb for motif,athena,tcl/tk,etc.)
> 
> René J.V. Bertin wrote:
>     I don't understand - that line is in a Q_WS_X11 code block? The code isn't mine, in case you're wondering why there's pure X11 code.
>     
>     I decided to keep krdb.cpp because of 2 reasons. First, it updates QSettings and I am not sure that that's redundant. Second, the default GTk in MacPorts is the X11 version. I don't know how good the native/aqua GTk has become, but things being what they are I prefer to keep the synchronisation to GTk as it is.

Sorry, I missed that there already where Q_WS_X11 checks.

There's btw. quite some rdb specific code chunk above your first #ifdef, doesn't break, but becomes pointless.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review66972
-----------------------------------------------------------


On Sept. 19, 2014, 6:13 nachm., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120287/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 6:13 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.
> The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.
> The oxygen style builds and looks good but shows some updating glitches due to compositing.
> 
> I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 195f99c 
>   kcontrol/CMakeLists.txt fc666b1 
>   kcontrol/krdb/krdb.cpp 36fc99c 
>   kcontrol/style/CMakeLists.txt d832b20 
>   libs/CMakeLists.txt c0576fe 
> 
> Diff: https://git.reviewboard.kde.org/r/120287/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140919/53567d84/attachment.html>