[KDE/Mac] Review Request 120150: [OS X] prevent another crash after finishing a code difference review

René J.V. Bertin rjvbertin at gmail.com
Fri Sep 12 20:30:39 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 12, 2014, 10:30 p.m.)

Review request for KDE Software on Mac OS X, KDevelop and Olivier Goffart.


Back to a more reasonable "deleteLater-instead-of-delete" approach. In indeed `m_patch` should better be deleted in deferred mode rather than immediately, this should probably be done both in the destructor (as in RR 120081) and in PatchReviewPlugin::setPatch. That may in fact even be the place where the actual "live" patch is deleted, because it looks like `setPatch` is called with a bogus patch when the Finish Review button is clicked.
In addition I added protection against null pointer dereference in the destructor - and added the explicit `disconnect` also done in `setPatch` (redundant in a dtor?).

Repository: kdevplatform


In https://reviewboard.kde.org/r/120081/ I proposed an (accepted) approach to prevent kdevelop from crashing after closing the patch review ("git/show differences") toolview. I had another of those crashes after heavier-than-usual perusal of the toolview, despite the previous patch. The attached patch replaces all `delete`s of `QObject` derived class instances with `deleteLater()`.

Diffs (updated)

  plugins/patchreview/patchreview.cpp 18b63db 

Diff: https://git.reviewboard.kde.org/r/120150/diff/


kdevplatform git/kde4-legacy on KDE/MacPorts OS X 10.6.8 . 


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140912/8bbabd74/attachment.html>

More information about the kde-mac mailing list