[KDE/Mac] [Kde-pim] Review Request 119533: Make ktimetracker build on OS X, where it uses a native method from the ApplicationServices framework for idle time detection, instead of the XScreenSaver.
cgiboudeaux at gmx.com
Sun Sep 7 19:59:47 UTC 2014
On Saturday 06 September 2014 13:25:27 René J.V. Bertin wrote:
> > On July 31, 2014, 2:10 p.m., Allen Winter wrote:
> > > CMakeLists.txt, line 310
> > > <https://git.reviewboard.kde.org/r/119533/diff/1/?file=294203#file294203
> > > line310>> >
> > > remove the conditional now
> > Allen Winter wrote:
> > If you don't have commit access, please let us know so someone else
> > can commit for you.>
> > René J.V. Bertin wrote:
> > That'd be the case - I removed the conditional since it's no longer
> > required, and uploaded a new, monolithic diff/patch file.
> I don't see my changes in kdepim git/kde4.14 (and no ktimetracker at all in
> git/master) - has this been committed by anyone?
> - René J.V.
That's unfortunate but expected.
The review request was created after the KDE/4.14 branch creation.
The change was only pushed to master since there was no unittest and the
comment in mainwindow.cpp indicates that it cannot end in a stable branch
without more testing.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: This is a digitally signed message part.
More information about the kde-mac