[KDE/Mac] Review Request 120081: [OS X] prevent a crash after finishing a code difference review

René J.V. Bertin rjvbertin at gmail.com
Sat Sep 6 17:05:21 UTC 2014

On Saturday September 06 2014 15:56:16 Marko Käning wrote:

> > Milian Wolff wrote:
> >     Interesting, I learned something new about QObject documentation. Anyhow, just don't write it should always be done and commit this patch :) I gave you the ship it already for that.

Good :)

> >     
> >     If you delete parent, either direct or indirect via `deleteLater()`, the children will always be deleted directly via the QObject destructor (or am I out of the loop there as well and they are also only deleted via `deleteLater`?.

You can do as I did, jump into the Qt sources and try to see what happens. deleteLater isn't declared virtual (so I'd have guessed calling it through a parent class wouldn't call the descendant class version, in pure C++); does the Q_SLOTS definition have a similar effect?

> >     Anyhow, unrelated to this patch, really. Please push this in - or don't you have commit rights?

Indeed I haven't. I've applied for them almost a week ago, guess I picked a sponsor who isn't in a hurry to make it happen :)


More information about the kde-mac mailing list