[KDE/Mac] Review Request 119844: [OS X] backend improvements for kwallet/Keychain integration

[René J.V. Bertin]

> On Sept. 5, 2014, 7:42 p.m., Marko Käning wrote:
> > tests/KWallet/kwallettest.cpp, line 54
> > <https://git.reviewboard.kde.org/r/119844/diff/4/?file=309940#file309940line54>
> >
> >     kWarning() is not known in kwallettest.cpp
> 
> Marko Käning wrote:
>     I've moved here the defines from qosxkeychain.cpp to kwallet.h and now everything builds and tests fine.
> 
> Marko Käning wrote:
>     BTW, installation on OSX/CI doesn't seem to run the tests at all. At least I can't find any test output. Perhaps this is due to the missing KF5Gpgmepp?
> 
> René J.V. Bertin wrote:
>     Sh@@t, I missed these, bummer.
>     
>     As to running the tests: I haven't seen that happen during normal kdelibs4 builds/installs either. I think they're supposed to be run by hand.
> 
> Marko Käning wrote:
>     That's odd, since I see tests like these in so many other frameworks being run during installation on the CI system. That's part of the quality checking.

I have no experience with the CI system, but for "standard" (end-user) builds they are skipped for good reason...

Does the CI system substitute user interaction? kwallettest creates a new wallet/keychain which requires setting a password, and then once more for unlocking it for the unlocking test.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119844/#review65843
-----------------------------------------------------------


On Sept. 5, 2014, 6:21 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119844/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 6:21 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API.
> 
> With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. In addition, password prompts no longer get posted somewhere in the background.
> 
> 
> Diffs
> -----
> 
>   src/api/KWallet/CMakeLists.txt 9709559 
>   src/api/KWallet/kwallet_mac.cpp d93e5ae 
>   src/api/KWallet/qosxkeychain.h PRE-CREATION 
>   src/api/KWallet/qosxkeychain.cpp PRE-CREATION 
>   tests/KWallet/CMakeLists.txt b155f64 
>   tests/KWallet/kwallettest.cpp 3351a6b 
> 
> Diff: https://git.reviewboard.kde.org/r/119844/diff/
> 
> 
> Testing
> -------
> 
> Testing and development of these was done on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment (https://trac.macports.org/ticket/44473). Since I am not currently able to build (parts of) KF5, porting of my modifications to KF5/KWallet has been done in source only. However, I have good hope that there will be little bugs to review in this request, given the lack of non-esthetic (formatting) modifications to the current kwallet_mac.cpp and kwallettest.cpp.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140905/990eff37/attachment.html>