[KDE/Mac] Review Request 119844: [OS X] backend improvements for kwallet/Keychain integration

[René J.V. Bertin]

> On Sept. 5, 2014, 12:12 a.m., Marko Käning wrote:
> > tests/KWallet/kwallettest.h, line 37
> > <https://git.reviewboard.kde.org/r/119844/diff/3/?file=309536#file309536line37>
> >
> >     This does not build on KF5 as is.

I actually have no idea what that statement is supposed to do (so while I could replace it with a QVERIFY2 equivalent I wouldn't know what kind of explicative text to add).
It seems nothing like this was present in the original kwallettest.h, so I removed the 2 lines; please let me know if that works better (I'll be updating the diff after looking into the other issue).


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119844/#review65815
-----------------------------------------------------------


On Sept. 3, 2014, 4:23 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119844/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 4:23 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API.
> 
> With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. In addition, password prompts no longer get posted somewhere in the background.
> 
> 
> Diffs
> -----
> 
>   tests/KWallet/kwallettest.h 2936ac1 
>   tests/KWallet/kwallettest.cpp 3351a6b 
>   src/api/KWallet/CMakeLists.txt 9709559 
>   src/api/KWallet/kwallet_mac.cpp d93e5ae 
>   src/api/KWallet/qosxkeychain.h PRE-CREATION 
>   src/api/KWallet/qosxkeychain.cpp PRE-CREATION 
>   tests/KWallet/CMakeLists.txt b155f64 
> 
> Diff: https://git.reviewboard.kde.org/r/119844/diff/
> 
> 
> Testing
> -------
> 
> Testing and development of these was done on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment (https://trac.macports.org/ticket/44473). Since I am not currently able to build (parts of) KF5, porting of my modifications to KF5/KWallet has been done in source only. However, I have good hope that there will be little bugs to review in this request, given the lack of non-esthetic (formatting) modifications to the current kwallet_mac.cpp and kwallettest.cpp.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140905/e2cb93d5/attachment.html>