[KDE/Mac] Review Request 119838: [OSX] backend improvements for kwallet/Keychain integration and AuthServices

[Marko Käning]

Hi René,

I am having a problem building kwallet with your patch applied:

---
[ 41%] Built target kwallettestlib
In file included from /Users/marko/WC/KDECI-builds/kwallet/build/tests/KWallet/kwallettest_automoc.cpp:2:
In file included from /Users/marko/WC/KDECI-builds/kwallet/build/tests/KWallet/moc_kwallettest.cpp:9:
/Users/marko/WC/KDECI-builds/kwallet/build/tests/KWallet/../../../tests/KWallet/kwallettest.h:37:10: error: expected member name or ';' after declaration specifiers
    void QVERIFY( bool keyDoesNotExist );
    ~~~~ ^
/opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/include/QtTest/qtestcase.h:63:28: note: expanded from macro 'QVERIFY'
#define QVERIFY(statement) \
                           ^
Scanning dependencies of target kwalletasync
In file included from /Users/marko/WC/KDECI-builds/kwallet/tests/KWallet/kwallettest.cpp:21:
/Users/marko/WC/KDECI-builds/kwallet/tests/KWallet/kwallettest.h:37:10: error: expected member name or ';' after declaration specifiers
    void QVERIFY( bool keyDoesNotExist );
    ~~~~ ^
/opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/include/QtTest/qtestcase.h:63:28: note: expanded from macro 'QVERIFY'
#define QVERIFY(statement) \
                           ^
/Users/marko/WC/KDECI-builds/kwallet/tests/KWallet/kwallettest.cpp:28:10: fatal error: 'kdebug.h' file not found
#include <kdebug.h>
         ^
[ 42%] Building CXX object tests/kwalletd/CMakeFiles/kwalletasync.dir/kwalletasync.cpp.o
1 error generated.
make[2]: *** [tests/KWallet/CMakeFiles/kwallettest.dir/kwallettest_automoc.cpp.o] Error 1
Scanning dependencies of target kwalletbackend5
make[2]: *** Waiting for unfinished jobs....
[ 43%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/blockcipher.cc.o
:
---

and I hope you know what to do about it. :)

The header kdebug.h seems to be outdated on KF5 and probably only QDebug needs to be included?
Cross-checking with kauth's tests might be useful here and I guess you’ll be faster than me in doing so. ;-)

Greets,
Marko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140905/0ee416b4/attachment.html>