[KDE/Mac] Review Request 119847: [OS X] backend improvements for AuthServices

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119847/#review65814
-----------------------------------------------------------


This patch for kauth has been successfully tested on KF5/OSX/CI.

It applies cleanly, builds fine and the two test cases pass!

- Marko Käning


On Aug. 19, 2014, 8 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119847/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 8 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> The proposed improvement to AuthServices consist in moving the authentication from the helper (back) to the client. They make it possible to edit the kwallet configuration in the associated control module (at least that's the effect under KDE 4.12.5 ...). And last but not least, password prompts no longer get posted somewhere in the background.
> 
> See also https://trac.macports.org/ticket/44655
> 
> 
> Diffs
> -----
> 
>   src/backends/mac/AuthServicesBackend.cpp e832bfe 
> 
> Diff: https://git.reviewboard.kde.org/r/119847/diff/
> 
> 
> Testing
> -------
> 
> Testing and development of these was done on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment. Since I am not currently able to build (parts of) KF5, porting of my modifications to KF5/KAuth has been done in source only. For src/backends/mac/AuthServicesBackend.cpp, I have good hope that there will be little bugs to review in this request, given how the current code is essentially identical.
> However, for KDE 4.1x I also made a small change to kauthactions.cpp, which I haven't been able to "place" in the current code. I attached the diff in question in hope that whoever tests this will know if it's still required (and if so, where it'd go).
> 
> 
> File Attachments
> ----------------
> 
> diff for kauthaction.cpp as required for KDE 4.12.5+
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/19/14adb704-b1c1-4fea-b3ec-e291e8d4f672__kauthaction.cpp.diff
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140904/9658af16/attachment-0001.html>