[KDE/Mac] Review Request 119838: [OSX] backend improvements for kwallet/Keychain integration and AuthServices

[Albert Astals Cid]

> On set. 2, 2014, 6:17 p.m., Albert Astals Cid wrote:
> > kdeui/tests/kwallettest.cpp, line 98
> > <https://git.reviewboard.kde.org/r/119838/diff/4/?file=309303#file309303line98>
> >
> >     Why would testKeys[0] be of type unknown? It should be of type stream since it's written with writeEntry(QString, QByteArray), and that says it writes a "binary" entry, no?
> 
> René J.V. Bertin wrote:
>     Honestly, I wouldn't know - and apparerently you aren't sure either? I wasn't aware that the Stream type was for binary entries, and it seemed logical that a generic entry written without type information would be of type Unknown. I thought I'd checked this on Linux, but I also notice that I have an older kwallettest.cpp on my Linux system. Bummer ...

I am not sure because i have no clue about the whole kwallet thing, but i have checked the code and it is what it does, and the test fails on linux, so assuming the linux implementation has not been wrong for decades I'm going to ask you to change it.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119838/#review65729
-----------------------------------------------------------


On set. 2, 2014, 3:25 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119838/
> -----------------------------------------------------------
> 
> (Updated set. 2, 2014, 3:25 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Valentin Rusu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API. The proposed improvement to AuthServices consist in moving the authentication from the helper (back) to the client.
> 
> With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. The modifications to the AuthServices make it possible to edit the kwallet configuration in the associated control module. And last but not least, password prompts no longer get posted somewhere in the background.
> 
> I'm bundling both in a single RR because even if they're independent they are strongly related.
> 
> 
> A more detailed discussion can be found on trac.macports.org:
> 
> https://trac.macports.org/ticket/44473
> https://trac.macports.org/ticket/44655
> 
> 
> Diffs
> -----
> 
>   cmake/modules/KDE4Macros.cmake bde7cfe 
>   kdecore/auth/backends/mac/AuthServicesBackend.cpp 56ef114 
>   kdecore/auth/kauthaction.cpp 8fbd61c 
>   kdeui/CMakeLists.txt b439e04 
>   kdeui/tests/CMakeLists.txt f661b91 
>   kdeui/tests/kwallettest.cpp 245959b 
>   kdeui/util/kwallet_mac.cpp a6bf4c0 
>   kdeui/util/qosxkeychain.h PRE-CREATION 
>   kdeui/util/qosxkeychain.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119838/diff/
> 
> 
> Testing
> -------
> 
> Development and testing was done under MacPorts on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment. Apart from regular use, I expanded/improved kdeui/tests/kwallettest.cpp and verified that XML exports of my Linux kwallets imported cleanly under OS X.
> I also copied modified kwallettest file into the 4.13.3 kdelibs tree on my Kubuntu 14.04 system and verified that it builds and runs without errors.
> 
> All patches from my 4.12.5 tree (and published in the trac tickets above) applied cleanly to the 4.13 and 4.14.60 (git/master as of earlier today) trees, the resulting code builds and kwallettest executes without errors.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140902/902e4cd3/attachment.html>