[KDE/Mac] Review Request 119838: [OSX] backend improvements for kwallet/Keychain integration and AuthServices

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119838/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 5:25 p.m.)


Review request for KDE Software on Mac OS X and Valentin Rusu.


Changes
-------

corrected 2 potential cases of CFRelease of a null pointer.


Repository: kdelibs


Description
-------

The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API. The proposed improvement to AuthServices consist in moving the authentication from the helper (back) to the client.

With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. The modifications to the AuthServices make it possible to edit the kwallet configuration in the associated control module. And last but not least, password prompts no longer get posted somewhere in the background.

I'm bundling both in a single RR because even if they're independent they are strongly related.


A more detailed discussion can be found on trac.macports.org:

https://trac.macports.org/ticket/44473
https://trac.macports.org/ticket/44655


Diffs (updated)
-----

  cmake/modules/KDE4Macros.cmake bde7cfe 
  kdecore/auth/backends/mac/AuthServicesBackend.cpp 56ef114 
  kdecore/auth/kauthaction.cpp 8fbd61c 
  kdeui/CMakeLists.txt b439e04 
  kdeui/tests/CMakeLists.txt f661b91 
  kdeui/tests/kwallettest.cpp 245959b 
  kdeui/util/kwallet_mac.cpp a6bf4c0 
  kdeui/util/qosxkeychain.h PRE-CREATION 
  kdeui/util/qosxkeychain.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119838/diff/


Testing
-------

Development and testing was done under MacPorts on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment. Apart from regular use, I expanded/improved kdeui/tests/kwallettest.cpp and verified that XML exports of my Linux kwallets imported cleanly under OS X.
I also copied modified kwallettest file into the 4.13.3 kdelibs tree on my Kubuntu 14.04 system and verified that it builds and runs without errors.

All patches from my 4.12.5 tree (and published in the trac tickets above) applied cleanly to the 4.13 and 4.14.60 (git/master as of earlier today) trees, the resulting code builds and kwallettest executes without errors.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140902/d8a180e6/attachment.html>