[KDE/Mac] Review Request 120800: prevent starting a QTimer with a negative interval

[René J.V. Bertin]

> On Oct. 30, 2014, 9:54 a.m., Dan Vrátil wrote:
> > server/src/collectionscheduler.cpp, line 85
> > <https://git.reviewboard.kde.org/r/120800/diff/3-4/?file=322697#file322697line85>
> >
> >     The curly brackets are not necessary. Also make it `const int` please.

I'm just about as "pedantic" about not letting temporary variables "linger" beyond the scope where they're required as you guys are about white space, but I concur that there's little hard reason for that kind scoping here :)


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120800/#review69509
-----------------------------------------------------------


On Oct. 30, 2014, 12:04 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120800/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 12:04 a.m.)
> 
> 
> Review request for Akonadi and KDE Software on Mac OS X.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> After waking my Mac from (a night's) sleep, I noticed a quickly repeating error message about starting a QTimer with a negative interval. I could trace this to the PausableTimer instance in collectionscheduler.cpp .
> The attached patch prevents the error condition by clipping the calculated remaining time interval to 0 .
> I've left a debug statement that can of course doesn't need to be committed.
> 
> 
> Diffs
> -----
> 
>   server/src/collectionscheduler.cpp 8d4cd5c 
> 
> Diff: https://git.reviewboard.kde.org/r/120800/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 with kdelibs 4.14.2 and kdepim* 4.13.3
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141030/a1d8af17/attachment.html>