[KDE/Mac] Review Request 120800: prevent starting a QTimer with a negative interval

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120800/#review69244
-----------------------------------------------------------



server/src/collectionscheduler.cpp
<https://git.reviewboard.kde.org/r/120800/#comment48408>

    Somehow this made the negative interval issue come back. Curiously, as with the original code, the warning message is printed much more often upstream by Qt than through the debug message in my previous "else" branch.
    I'll try using a temp. variable - it'll be optimised away by the compiler (clang in my case) but might prevent issues with using calling `interval()` twice in rapid succession.


- René J.V. Bertin


On Oct. 27, 2014, 11:21 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120800/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 11:21 p.m.)
> 
> 
> Review request for Akonadi and KDE Software on Mac OS X.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> After waking my Mac from (a night's) sleep, I noticed a quickly repeating error message about starting a QTimer with a negative interval. I could trace this to the PausableTimer instance in collectionscheduler.cpp .
> The attached patch prevents the error condition by clipping the calculated remaining time interval to 0 .
> I've left a debug statement that can of course doesn't need to be committed.
> 
> 
> Diffs
> -----
> 
>   server/src/collectionscheduler.cpp 8d4cd5c 
> 
> Diff: https://git.reviewboard.kde.org/r/120800/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 with kdelibs 4.14.2 and kdepim* 4.13.3
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141028/a166e8ba/attachment.html>