[KDE/Mac] Review Request 120800: prevent starting a QTimer with a negative interval

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120800/#review69220
-----------------------------------------------------------


Thanks for looking into this, runtime warnings bother me too. But is there any point in that debug statement? Debugging? I'm curious too about how the timer could still be active at the time of the pausing, if it was after interval(). Maybe this is because setInterval was called later. But that means testing  mStarted.secsTo( mPaused ) at the time of the call to pause() too? Anyway, better finish the debugging (to fully understand the issue) than commit debug output and hope someone else will finish the debugging :-)


server/src/collectionscheduler.cpp
<https://git.reviewboard.kde.org/r/120800/#comment48389>

    indentation of all the new code seems off -- or is that just reviewboard?



server/src/collectionscheduler.cpp
<https://git.reviewboard.kde.org/r/120800/#comment48388>

    That bit (mPaused set to invalid datetime, and mStarted set to "now") happens anyway, so I don't see the relation with the issue? IMO it's confusing to have that in the debug output if it's not related to the issue (remainder being negative)


- David Faure


On Oct. 25, 2014, 8:52 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120800/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2014, 8:52 p.m.)
> 
> 
> Review request for Akonadi and KDE Software on Mac OS X.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> After waking my Mac from (a night's) sleep, I noticed a quickly repeating error message about starting a QTimer with a negative interval. I could trace this to the PausableTimer instance in collectionscheduler.cpp .
> The attached patch prevents the error condition by clipping the calculated remaining time interval to 0 .
> I've left a debug statement that can of course doesn't need to be committed.
> 
> 
> Diffs
> -----
> 
>   server/src/collectionscheduler.cpp 8d4cd5c 
> 
> Diff: https://git.reviewboard.kde.org/r/120800/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 with kdelibs 4.14.2 and kdepim* 4.13.3
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141027/4e6d9b10/attachment.html>