[KDE/Mac] Review Request 120648: Encode the URIs which end up in DTD files

[Luigi Toscano]

> On Ott. 19, 2014, 12:52 p.m., Alex Merry wrote:
> > src/CMakeLists.txt, line 19
> > <https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19>
> >
> >     You've already included it above...

This is different, it's in a piece of code inside install(CODE...) which is executed in a different moment (installation time). From my quick test it seems I need the previous include is in a different scope.


> On Ott. 19, 2014, 12:52 p.m., Alex Merry wrote:
> > cmake/uriencode.cmake, line 14
> > <https://git.reviewboard.kde.org/r/120648/diff/1/?file=320539#file320539line14>
> >
> >     You may want to consider using `string(REPLACE)` to escape double-quote chars in `${_original_uri}`, like
> >     
> >         string(REPLACE "\"" "\\"" escaped_uri "${${_original_uri}}")
> >     
> >     and then use `${escaped_uri}` in the perl script.

Added to the function, thanks.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68696
-----------------------------------------------------------


On Ott. 18, 2014, 5:50 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
> 
> (Updated Ott. 18, 2014, 5:50 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
> 
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 341ecf4 
>   cmake/uriencode.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
> 
> 
> Testing
> -------
> 
> It compiles, but I can't properly test Mac and Windows scenarios
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141020/cacc6151/attachment.html>